This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA-v2] Fix ARI warning about function call in first column
- From: Tom Tromey <tromey at redhat dot com>
- To: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Eli Zaretskii'" <eliz at gnu dot org>, <gdb-patches at sourceware dot org>
- Date: Mon, 14 Mar 2011 11:17:30 -0600
- Subject: Re: [RFA-v2] Fix ARI warning about function call in first column
- References: <20110312015329.GA20179@sourceware.org> <010f01cbe157$aebb5cb0$0c321610$%muller@ics-cnrs.unistra.fr> <18667.385276831$1300008680@news.gmane.org> <m3vczldagl.fsf@fleche.redhat.com> <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr> <83oc5dr6pj.fsf@gnu.org> <10281.0550401502$1300122152@news.gmane.org>
Eli> I see no problem with long lines, if there are no better alternatives.
I agree. Sometimes there really is no good answer and you just have to
pick the least worst.
Pierre> I hope everyone is OK with this.
Pierre> I think that we do have lots of other occurrences
Pierre> of lines longer than 80 cols anyhow...
It is fine.
Pierre> +static struct varobj * varobj_add_child (struct varobj *var,
Pierre> + const char *name,
Pierre> + struct value *value);
Extra space after the "*".
Pierre> +extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct
Likewise.
Pierre> +struct displaced_step_closure* get_displaced_step_closure_by_addr
Space is on the wrong side of the "*"; I know you didn't cause this but
if you are fixing the indentation anyway...
Tom