This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[RFA] Fix formatting in [RFA-v2] Fix ARI warning about function call in first column


 
> Pierre> +static struct varobj * varobj_add_child (struct varobj *var,
> Pierre> +					 const char *name,
> Pierre> +					 struct value *value);
> 
> Extra space after the "*".
> 
> Pierre> +extern struct hppa_objfile_private *
> hppa_init_objfile_priv_data (struct
> 
> Likewise.
> 
> Pierre> +struct displaced_step_closure*
> get_displaced_step_closure_by_addr
> 
> Space is on the wrong side of the "*"; I know you didn't cause this but
> if you are fixing the indentation anyway...
> 
> Tom

  Is this OK like below?

 Or should I still add the function declarations
on which the change is applied (which I did not
add in my previous ChangeLog entry).

Pierre

ChangeLog entry:

2011-03-15  Pierre Muller  <muller@ics.u-strasbg.fr>

	Fix formatting of functions returning a pointer in previous commit.
	* varobj.c: Ditto.
	* hppa-tdep.h: Ditto.
	* inferior.h: Ditto.

Index: hppa-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.h,v
retrieving revision 1.42
diff -r1.42 hppa-tdep.h
243c243
< extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct
objfile *objfile);
---
> extern struct hppa_objfile_private *hppa_init_objfile_priv_data (struct
objfile *objfile);
Index: inferior.h
===================================================================
RCS file: /cvs/src/src/gdb/inferior.h,v
retrieving revision 1.153
diff -r1.153 inferior.h
369c369
< struct displaced_step_closure* get_displaced_step_closure_by_addr
(CORE_ADDR addr);
---
> struct displaced_step_closure *get_displaced_step_closure_by_addr
(CORE_ADDR addr);
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.173
diff -r1.173 varobj.c
299,301c299,301
< static struct varobj * varobj_add_child (struct varobj *var,
< 					 const char *name,
< 					 struct value *value);
---
> static struct varobj *varobj_add_child (struct varobj *var,
> 					const char *name,
> 					struct value *value);


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]