This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] Fix formatting in [RFA-v2] Fix ARI warning about function call in first column
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: "'Tom Tromey'" <tromey at redhat dot com>
- Cc: <gdb-patches at sourceware dot org>
- Date: Tue, 15 Mar 2011 11:49:57 +0100
- Subject: [RFA] Fix formatting in [RFA-v2] Fix ARI warning about function call in first column
- References: <20110312015329.GA20179@sourceware.org> <010f01cbe157$aebb5cb0$0c321610$%muller@ics-cnrs.unistra.fr> <18667.385276831$1300008680@news.gmane.org> <m3vczldagl.fsf@fleche.redhat.com> <001401cbe261$5490ec40$fdb2c4c0$%muller@ics-cnrs.unistra.fr> <83oc5dr6pj.fsf@gnu.org> <10281.0550401502$1300122152@news.gmane.org> <m3bp1dd3kl.fsf@fleche.redhat.com>
> Pierre> +static struct varobj * varobj_add_child (struct varobj *var,
> Pierre> + const char *name,
> Pierre> + struct value *value);
>
> Extra space after the "*".
>
> Pierre> +extern struct hppa_objfile_private *
> hppa_init_objfile_priv_data (struct
>
> Likewise.
>
> Pierre> +struct displaced_step_closure*
> get_displaced_step_closure_by_addr
>
> Space is on the wrong side of the "*"; I know you didn't cause this but
> if you are fixing the indentation anyway...
>
> Tom
Is this OK like below?
Or should I still add the function declarations
on which the change is applied (which I did not
add in my previous ChangeLog entry).
Pierre
ChangeLog entry:
2011-03-15 Pierre Muller <muller@ics.u-strasbg.fr>
Fix formatting of functions returning a pointer in previous commit.
* varobj.c: Ditto.
* hppa-tdep.h: Ditto.
* inferior.h: Ditto.
Index: hppa-tdep.h
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.h,v
retrieving revision 1.42
diff -r1.42 hppa-tdep.h
243c243
< extern struct hppa_objfile_private * hppa_init_objfile_priv_data (struct
objfile *objfile);
---
> extern struct hppa_objfile_private *hppa_init_objfile_priv_data (struct
objfile *objfile);
Index: inferior.h
===================================================================
RCS file: /cvs/src/src/gdb/inferior.h,v
retrieving revision 1.153
diff -r1.153 inferior.h
369c369
< struct displaced_step_closure* get_displaced_step_closure_by_addr
(CORE_ADDR addr);
---
> struct displaced_step_closure *get_displaced_step_closure_by_addr
(CORE_ADDR addr);
Index: varobj.c
===================================================================
RCS file: /cvs/src/src/gdb/varobj.c,v
retrieving revision 1.173
diff -r1.173 varobj.c
299,301c299,301
< static struct varobj * varobj_add_child (struct varobj *var,
< const char *name,
< struct value *value);
---
> static struct varobj *varobj_add_child (struct varobj *var,
> const char *name,
> struct value *value);