Re: [patch] Fix empty PC range psymtab<->symtab discrepancy

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> For DW_AT_high_pc DWARF-4 has the comment
Jan> 	The high PC value may be beyond the last valid instruction in the
Jan> 	executable.
Jan> which may suggest DW_AT_low_pc == DW_AT_high_pc == 0 may be valid
Jan> and it should mean the whole address space.  I find such case
Jan> outside of the scope of this patch, such case already did not work
Jan> as the partial symtabs reading already ignored DIEs with
Jan> DW_AT_low_pc == DW_AT_high_pc.

I would not worry about this case at all.

The patch looks good to me.

Jan> +	  complaint (&symfile_complaints,
Jan> +		     _("DW_AT_low_pc %s is not < DW_AT_high_pc %s "
Jan> +		       "for DIE at 0x%x [in module %s]"),
Jan> +		     paddress (gdbarch, part_die->lowpc),
Jan> +		     paddress (gdbarch, part_die->highpc),
Jan> +		     part_die->offset, cu->objfile->name);

Thanks for putting this info into the complaint.
One of my minor wish-list items is that we would do this for all DWARF
complaints.

Tom