This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: bfin: add GPIO device simulation
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Tue, 15 Mar 2011 09:01:45 -0700
- Subject: Re: [PATCH] sim: bfin: add GPIO device simulation
- References: <1300177576-14212-1-git-send-email-vapier@gentoo.org>
> 2011-03-15 Mike Frysinger <vapier@gentoo.org>
>
> * Makefile.in (dv-bfin_gpio.o): New target.
> * configure.ac (SIM_AC_OPTION_HARDWARE): Add bfin_gpio.
> * configure: Regenerate.
> * dv-bfin_gpio.c, dv-bfin_gpio.h: New files.
> * machs.c: Include dv-bfin_gpio.h.
> (bf50x_mem, bf51x_mem, bf52x_mem, bf531_mem, bf532_mem, bf533_mem,
> bf534_mem, bf536_mem, bf537_mem, bf538_mem, bf561_mem, bf592_mem):
> Delete GPIO memory stubs.
> (bf50x_dev, bf512_dev, bf516_dev, bf522_dev, bf526_dev, bf533_dev,
> bf534_dev, bf537_dev, bf538_dev, bf561_dev, bf592_dev): Add GPIO
> peripheral devices.
> (bfin_model_hw_tree_init): Hook up GPIO interrupts to SIC.
OK, with a couple of formatting nits:
> +static const char * const mmr_names[] = {
Curly brace on the next line.
> +static const struct hw_port_descriptor bfin_gpio_ports[] = {
Ditto.
> +const struct hw_descriptor dv_bfin_gpio_descriptor[] = {
Bis repetita.
> diff --git a/sim/bfin/machs.c b/sim/bfin/machs.c
[...]
> @@ -95,11 +96,8 @@ static const struct bfin_dmac_layout bf000_dmac[] = {};
> #define bf504_chipid bf50x_chipid
> #define bf506_chipid bf50x_chipid
> static const struct bfin_memory_layout bf50x_mem[] = {
As a followup patch, you might want to fix these types of
formatting issues. It's not very important, but might as well
make it right when you have the time...
--
Joel