This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Re: Advice on fixing gdb/12528


On Tue, Mar 15, 2011 at 11:36 AM, Jan Kratochvil
<jan.kratochvil@redhat.com> wrote:

>> ? ? ? ?PR gdb/12528
>> ? ? ? ?* gdb.dwarf2/break-on-linker-gcd-function.exp: New test.
>> ? ? ? ?* gdb.dwarf2/break-on-linker-gcd-function.cc: New file.
>
> It seems correct to me, please check it in.

Is location of the test case ok?

The same problem could well exist on non-dwarf platforms.

I also noticed that gdb.dwarf2/Makefile.in would need to have
break-on-linker-gcd-function added to EXECUTABLES (or the executable
renamed to break-on-linker-gcd-function.x).

>> +# This accepts e.g. "Breakpoint 1 at 0x40968a" (fixed GDB)
>> +# but rejects e.g. "Breakpoint 1 at 0x4" (broken GDB).
>> +gdb_test "b [gdb_get_line_number "gdb break here"]" "Breakpoint \[0-9\] at 0x\[0-9a-f\]\[0-9a-f\]+: .*"
>
> I was thinking if some prologue cannot be >=0x10 due to some alignments etc.

Perhaps "[$hex][$hex][$hex]+" to weed out up to 0xff ?

Thanks,
-- 
Paul Pluzhnikov


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]