This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [RFA] make first parameter of to_lookup_symbol const char *

From: Tom Tromey <tromey at redhat dot com>
To: Joel Brobecker <brobecker at adacore dot com>
Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Pedro Alves <pedro at codesourcery dot com>, Tristan Gingold <gingold at adacore dot com>, "gdb-patches\ at sourceware dot org ml" <gdb-patches at sourceware dot org>
Date: Wed, 16 Mar 2011 08:40:52 -0600
Subject: Re: [RFA] make first parameter of to_lookup_symbol const char *
References: <58CFFAD9-1C02-4AD8-B416-FC48D1A7F006@adacore.com> <20110314134616.GA2680@host1.jankratochvil.net> <20110316135810.GA6590@adacore.com>

>>>>> "Joel" == Joel Brobecker <brobecker@adacore.com> writes:

Joel> This is what it looks like to remove the target_ops method. It feels
Joel> a little like excising a potentially useful feature, so I'm not going
Joel> to commit without review, although there is no sign that we'll ever
Joel> need it any time soon.  But I added a comment explaining what we used
Joel> to do, to give us a clue later on, if we encounter a target where
Joel> we might need something of this kind.

I think it is a good idea to remove unused code.  If it is needed in the
future, it is simple enough to resurrect or rewrite this code.

The patch looks fine to me.

Tom

References:
- [RFA] make first parameter of to_lookup_symbol const char *
  - From: Tristan Gingold
- Re: [RFA] make first parameter of to_lookup_symbol const char *
  - From: Jan Kratochvil
- Re: [RFA] make first parameter of to_lookup_symbol const char *
  - From: Joel Brobecker

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]