This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFC] Question about CODESET macro inside config/djgpp/langinfo.h
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Eli Zaretskii'" <eliz at gnu dot org>
- Date: Mon, 21 Mar 2011 16:54:56 +0100
- Subject: [RFC] Question about CODESET macro inside config/djgpp/langinfo.h
Also about macros removal inside config subdirectory:
I was wondering about the usefulness of CODESET macro definition
inside
config/djgpp/langinfo.h
#define CODESET CODESET
while CODESET is itself a member of an enumeration.
Albeit harmless, this is listed as a macro to remove...
I don't see any code testing for the presence of this macro.
The configure script should work unchanged if we remove that line, no?
I also looked into config/djgpp/djconfig.sh
and I don't see where it could trigger any change.
Any objection to remove that macro?
Pierre Muller
Changelog entry:
2011-03-21 Pierre Muller <muller@ics.u-strasbg.fr>
* config/djgpp/langinfo.h (CODESET macro): Remove.
Pierre@E6510-Muller ~/git/archer
$ git diff gdb/config/djgpp
diff --git a/gdb/config/djgpp/langinfo.h b/gdb/config/djgpp/langinfo.h
index d3a5672..a624f78 100644
--- a/gdb/config/djgpp/langinfo.h
+++ b/gdb/config/djgpp/langinfo.h
@@ -28,8 +28,6 @@ enum {
_NL_NUM
};
-#define CODESET CODESET
-
extern char *nl_langinfo (nl_item);
#endif /* _LANGINFO_H */