This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] sim: bfin: fix thinko in SIC pin encoding
- From: Mike Frysinger <vapier at gentoo dot org>
- To: gdb-patches at sourceware dot org
- Cc: toolchain-devel at blackfin dot uclinux dot org
- Date: Wed, 23 Mar 2011 23:10:55 -0400
- Subject: Re: [PATCH] sim: bfin: fix thinko in SIC pin encoding
- References: <1300857306-7437-1-git-send-email-vapier@gentoo.org>
On Wed, Mar 23, 2011 at 01:15, Mike Frysinger wrote:
> When encoding the SIC/pin info into unique input port ids, I used bases
> of 100 when I meant to use 0x100. ÂRather than simply fix the decoding
> math in the different functions, create a few helper macros to simplify
> the SIC/pin encoding and decoding steps. ÂThis makes the resulting tables
> nice & clear.
after looking over this a bit more, i realized that the clean up also
allowed for merging of the bf533/bf537 port event handlers. so i did
that.
difference is reflected in:
(bfin_sic_533_port_event): Delete.
(bfin_sic_finish): Call set_hw_port_event with
bfin_sic_537_port_event for BF533 and BF59x targets.
-mike