This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v2] sim: cfi: new flash device simulation
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Thu, 24 Mar 2011 08:14:03 -0700
- Subject: Re: [PATCH v2] sim: cfi: new flash device simulation
- References: <1293750414-14626-1-git-send-email-vapier@gentoo.org> <1300945105-25242-1-git-send-email-vapier@gentoo.org>
> 2010-12-30 Mike Frysinger <vapier@gentoo.org>
>
> * aclocal.m4 (SIM_AC_OPTION_HARDWARE): Add cfi to default list.
> * Make-common.in (dv-cfi.o): New rule.
> * dv-cfi.c, dv-cfi.h: New files.
Almost OK.
There are just a few minor comments:
- opening curly brace in struct union declarations should be on
the next line
- We're not fond of commented out code. You could replace it by
a comment if useful.
- I realize that this is a large-ish job, but it would be nice to
have all types and routines documented. Generally, it's even
preferable to document the fields in the struct/union types,
but a small description of the type will be a good start for now.
- I think that this deserves a NEWS entry
- And I think that we should add some documentation in the GDB
Manual. The simulator section is almost non-existent in the
current manual, but if we could start defining a general structure,
even if they are empty, and document this new feature in that
structure, at least we won't make things worse.
--
Joel