This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH v3] sim: cfi: new flash device simulation
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Fri, 25 Mar 2011 08:46:34 -0700
- Subject: Re: [PATCH v3] sim: cfi: new flash device simulation
- References: <1293750414-14626-1-git-send-email-vapier@gentoo.org> <1301012212-2372-1-git-send-email-vapier@gentoo.org>
> gdb/:
> 2011-03-24 Mike Frysinger <vapier@gentoo.org>
>
> * NEWS: Mention new cfi device simulation.
>
> sim/common/:
> 2011-03-24 Mike Frysinger <vapier@gentoo.org>
>
> * aclocal.m4 (SIM_AC_OPTION_HARDWARE): Add cfi to default list.
> * Make-common.in (dv-cfi.o): New rule.
> * dv-cfi.c, dv-cfi.h: New files.
It's great to see the code with the comments, thanks! If you are going
to produce a 4th version based on Frank's comments, it would be nice
to reformat the comments a little to limit the length to 70 characters.
That's the soft limit we decided on recently. We allow ourselves to go
beyond that limit if it helping making thing less ugly, but otherwise,
we try to stay within that limit. If you're not going to produce
a new version, then no worries about that.
--
Joel