This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC 9/9] Unify windows specifics into common/windows-hdep files


> From: "Pierre Muller" <pierre.muller@ics-cnrs.unistra.fr>
> Date: Wed, 30 Mar 2011 14:05:17 +0200
> 
>    if (strcasecmp (buf, "ntdll.dll") == 0)
>      {
> -      GetSystemDirectory (buf, sizeof (buf));
> +      GetSystemDirectoryA (buf, sizeof (buf));

This will be a problem if we ever support a _UNICODE build.

> +      if (windows_conv_path (WINDOWS_POSIX_TO_NATIVE, exec_file, real_path,
> +			     __PMAX * sizeof (win_buf_t)) < 0)
>  	error (_("Error starting executable: %d"), errno);

But windows_conv_path never returns a negative value, it returns zero
if it fails.

Thanks.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]