This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 1/2] Remove old Cygwin1.5 support
- From: Christopher Faylor <cgf-use-the-mailinglist-please at sourceware dot org>
- To: gdb-patches at sourceware dot org
- Date: Thu, 7 Apr 2011 17:24:38 -0400
- Subject: Re: [RFA 1/2] Remove old Cygwin1.5 support
- References: <004e01cbf4ae$1cea8710$56bf9530$@muller@ics-cnrs.unistra.fr>
On Thu, Apr 07, 2011 at 12:58:14AM +0200, Pierre Muller wrote:
>As Christopher Faylor told me that my previous patch series
>was much too bulky compared to the added value,
>I will try to split it in little parts.
>
>The first two patches concern the removal of Cygwin 1.5 support has he
>suggested. This allows some simplifications in windows-nat.c code
>and I will try to further reduce cygwin/mingw differences in subsequent
>patches.
>
>This first part just removes the macros that are used to support Cygwin 1.5
>in remote-fileio.c and windows-nat.c
>The second part updates gdbserver/win32-low.c to use the
>new cygwin_conv_path and cygwin_conv_path_list functions
>in order to avoid build failure due to deprecated warning.
>
>Does anyone object to the idea of removing old Cygwin support?
>Christopher, is this patch acceptable as is?
>
>Pierre Muller.
>
>2011-04-07 Pierre Muller <muller@ics.u-strasbg.fr>
>
> Remove support for old Cygwin 1.5 versions.
> * remote-fileio.c: Remove macros used to emulate new
>cygwin_conv_path
> function on old Cygwin version.
> * windows-nat.c: Remove cygwin version check and always define
> __USEWIDE for Cygwin compilation.
Looks good. Please check in. I can't approve the gdbserver patch since
I don't believe I have that privilege.
cgf