This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[RFA] xtensa-tdep.c ARI fixes
- From: "Pierre Muller" <pierre dot muller at ics-cnrs dot unistra dot fr>
- To: <gdb-patches at sourceware dot org>
- Cc: "'Maxim Grigoriev'" <maxim at tensilica dot com>
- Date: Sat, 9 Apr 2011 11:42:29 +0200
- Subject: [RFA] xtensa-tdep.c ARI fixes
This patch removes three ARI warnings from xtensa-tdep.c
source code.
The only non-trivial change is in xtensa_register_type:
this is mainly because I do not understand the old code:
it was using both xmalloc and strdup, which should
create a memory leak, no?
But maybe I miss something?
Pierre Muller
as ARI maintainer.
2011-04-09 Pierre Muller <muller@ics.u-strasbg.fr>
ARI cleanup.
* xtensa-tdep.c (xtensa_register_type): Use xstrprintf instead of
sprintf. Simplify code.
(xtensa_register_reggroup_p): Extract assignment out of IF clause.
(call0_frame_cache): Remove && operator from end of line.
Index: xtensa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/xtensa-tdep.c,v
retrieving revision 1.57
diff -u -p -r1.57 xtensa-tdep.c
--- xtensa-tdep.c 18 Mar 2011 18:52:32 -0000 1.57
+++ xtensa-tdep.c 9 Apr 2011 09:22:52 -0000
@@ -318,15 +318,14 @@ xtensa_register_type (struct gdbarch *gd
if (tp == NULL)
{
- char *name = xmalloc (16);
+ char *name = xstrprintf ("int%d", size * 8);
tp = xmalloc (sizeof (struct ctype_cache));
tp->next = tdep->type_entries;
tdep->type_entries = tp;
tp->size = size;
- sprintf (name, "int%d", size * 8);
tp->virtual_type
- = arch_integer_type (gdbarch, size * 8, 1, xstrdup
(name));
+ = arch_integer_type (gdbarch, size * 8, 1, name);
}
reg->ctype = tp->virtual_type;
@@ -843,7 +842,8 @@ xtensa_register_reggroup_p (struct gdbar
if (group == restore_reggroup)
return (regnum < gdbarch_num_regs (gdbarch)
&& (reg->flags & SAVE_REST_FLAGS) == SAVE_REST_VALID);
- if ((cp_number = xtensa_coprocessor_register_group (group)) >= 0)
+ cp_number = xtensa_coprocessor_register_group (group);
+ if (cp_number >= 0)
return rg & (xtRegisterGroupCP0 << cp_number);
else
return 1;
@@ -2715,9 +2715,9 @@ call0_frame_cache (struct frame_info *th
too bad. */
int i;
- for (i = 0;
- (i < C0_NREGS) &&
- (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
+ for (i = 0;
+ (i < C0_NREGS)
+ && (i == C0_RA || cache->c0.c0_rt[i].fr_reg != C0_RA);
++i);
if (i >= C0_NREGS && cache->c0.c0_rt[C0_RA].fr_reg == C0_RA)
i = C0_RA;