This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [PATCH] gdb: sim: add command line completion
- From: Tom Tromey <tromey at redhat dot com>
- To: Mike Frysinger <vapier at gentoo dot org>
- Cc: gdb-patches at sourceware dot org, toolchain-devel at blackfin dot uclinux dot org
- Date: Thu, 14 Apr 2011 14:01:50 -0600
- Subject: Re: [PATCH] gdb: sim: add command line completion
- References: <1302219156-9055-1-git-send-email-vapier@gentoo.org>
>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:
Mike> For now, only the sub-command name is completed. No support yet for
Mike> completing options to that command. But even this is a huge step as
Mike> currently, nothing is completed, and the basic "help sim" is fairly
Mike> obtuse as to what exactly the "sim" command accepts.
Thanks for doing this.
Mike> +char **sim_command_completer (struct cmd_list_element *ignore,
Mike> + char *text, char *word)
I think this could be static.
And, newline after the initial "char **".
I don't really know anything about sim, but I didn't see anything
obviously bad in there. So, ok with the above change.
Tom