This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA-v2] Handle cygwin wchar_t specifics
- From: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: "'Tom Tromey'" <tromey at redhat dot com>, gdb-patches at sourceware dot org
- Date: Sun, 17 Apr 2011 00:34:57 +0200
- Subject: Re: [RFA-v2] Handle cygwin wchar_t specifics
- References: <5928.31498147479$1302882967@news.gmane.org> <m3ei53cres.fsf@fleche.redhat.com> <005101cbfc50$193136b0$4b93a410$@muller@ics-cnrs.unistra.fr> <20110416162455.GA5599@host1.jankratochvil.net> <000001cbfc7d$3f67f440$be37dcc0$@muller@ics-cnrs.unistra.fr>
On Sat, 16 Apr 2011 23:28:35 +0200, Pierre Muller wrote:
> --- config.in 17 Mar 2011 13:19:09 -0000 1.125
> +++ config.in 16 Apr 2011 21:19:47 -0000
> --- configure 17 Mar 2011 13:19:09 -0000 1.329
> +++ configure 16 Apr 2011 21:19:52 -0000
You do not have to post autogenerated files here, it was posted only due to
your request for your convenience before.
> --- gdb_wchar.h 1 Jan 2011 15:33:05 -0000 1.6
> +++ gdb_wchar.h 16 Apr 2011 21:19:57 -0000
> @@ -60,6 +60,7 @@
>
> #include <wchar.h>
> #include <wctype.h>
> +#include "config.h"
I would say rather #include "defs.h" and as the first #include line.
> +#define STR_VAL1(X) #X
> +#define STR_VAL(X) STR_VAL1(X)
This is called XSTRING in include/symcat.h.
> +#define SIZEOF_WCHAR_T_STR STR_VAL(SIZEOF_WCHAR_T)
^^ space - coding style
> -/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4.
> +/* If __STDC_ISO_10646__ is defined, then the host wchar_t is UCS-4 or
> UCS-2.
Corrupted diff by your mailer word wrapping.
These are just technical notes, no real review/approval.
Thanks,
Jan