This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Typedef'd method parameters [1/4]


>>>>> "Keith" == Keith Seitz <keiths@redhat.com> writes:

Keith> As I mentioned in the preamble for this patchset, this patch
Keith> changes cp-name-parser.y to not use shared memory. This is
Keith> accomplished by changing the return type of
Keith> cp_demangled_name_to_comp to return a pointer to a structure
Keith> which contains the relevant storage bits.

It took me a while to understand this since for some reason I was
thinking your patch was going to make the parser reentrant.  But of
course we don't need that -- we just need to be able to call the parser
twice and have both results remain valid.

Keith> I have not bothered with storing the error messages: one error
Keith> and the whole thing bows out anyway. Well, that and not a single
Keith> caller actually ever uses it. [Future cleanup to remove *errmsg
Keith> from cp-name-parser.y?]

Having the error seems handy; but the current formatting code for the
error (using snprintf) leaves something to be desired.

Keith> Comment/questions/concerns?

This is ok.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]