This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Marek Polacek <mpolacek at redhat dot com>
- Cc: "gdb-patches at sourceware dot org" <gdb-patches at sourceware dot org>
- Date: Wed, 27 Apr 2011 08:05:29 -0700
- Subject: Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)
- References: <4DB82F26.30801@redhat.com>
> Thus, my point is that we could replace those "send_gdb + sleep +
> gdb_expect" sequences with just one gdb_test{,multiple,no_output}. I
> don't know yet if this transformation is possible for every test in
> the completion.exp file. Maybe the changes would be quite dramatical.
> However, this test would be _much_ simpler and much faster. Also, the
> current formatting is ugly ;).
>
> So, do you think this is a good idea? Is there something I'm missing?
I don't know the history of the testcase, and this is only my own
opinion, but I tend to agree with you. I think we should keep one
test with \t, to make sure that a tab does trigger the completion,
but the rest of the testcase should be using the "complete" command.
That's what we do at AdaCore anyways...
--
Joel