This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: New ARI warning Wed Apr 27 01:54:55 UTC 2011


On 04/27/2011 11:08 PM, Joel Brobecker wrote:
>> sys/wait.h is included for macro __WALL.  However, we can safely remove
>> this include from common/linux-ptrace.h because either sys/wait.h or
>> gdb_wait.h is included before including linux-ptrace.h in linux-nat.c
>> and linux-low.c.
> 
> That's the only pragmatic answer that we have right now, but I do
> think that this is an extremely bad practice. Or maybe I'm biased
> by my past as an Ada developer...
> 
> Sooner or later, we'll have to move these header files to the common
> area as well.
> 

Yes, I agree.  So far, gdb code is using gdb_wait.h and gdbserver is
using sys/wait.h.  gdb_wait.h looks quite independent of gdb or
gdbserver.  Is there any known reason that we can't use gdb_wait.h in
gdbserver?  I don't see any.

-- 
Yao (éå)


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]