This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC] Fixing gdb.base/completion.exp (PR testsuite/12649)


On 04/28/2011 05:14 PM, Pedro Alves wrote:
> Are you sure?  I did't see that when I try it.

For instance this is OK:
gdb_test_no_output "complete hfgfh" "complete 'hfgfh'"

but this is not:
gdb_test_no_output "hfgfh\t" "complete 'hfgfh'"

> And I'd much rather we do this (remote the races) as first step instead
> of completely rewriting the whole test file into something completely
> different...

Good point.

> A follow up step would convert/simplify the send_gdb+gdb_expects
> into gdb_test&friends.

Something like this attempt?
http://sourceware.org/ml/gdb-patches/2011-04/msg00538.html

> Here's a better one.  

Perfect!  It looks good--seems like all the racy cases are gone.  Should this be
applied now?

Thank you.

	Marek


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]