This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA] Update cygwin specific code in nto-tdep.c
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Pierre Muller <pierre dot muller at ics-cnrs dot unistra dot fr>
- Cc: gdb-patches at sourceware dot org
- Date: Mon, 2 May 2011 14:36:35 -0700
- Subject: Re: [RFA] Update cygwin specific code in nto-tdep.c
- References: <000301cbfe90$cda6fd90$68f4f8b0$@muller@ics-cnrs.unistra.fr>
> 2011-04-19 Pierre Muller <muller@ics.u-strasbg.fr>
>
> * nto-tdep.c (nto_target): Replace deprecated call to
> cygwin_conv_to_posix_path functions by cygwin_conv_path calls.
Has this been reviewed? If not, this looks OK to me.
Note that stricktly speaking, the call to cygwin_conv_path is made
such that a relative path from QNX_TARGET is not preserved relative
anymore. Looking at the usage, I think that's an improvement, though.
> Index: nto-tdep.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/nto-tdep.c,v
> retrieving revision 1.41
> diff -u -p -r1.41 nto-tdep.c
> --- nto-tdep.c 19 Apr 2011 11:38:40 -0000 1.41
> +++ nto-tdep.c 19 Apr 2011 12:46:21 -0000
> @@ -59,9 +59,9 @@ nto_target (void)
> #ifdef __CYGWIN__
> static char buf[PATH_MAX];
> if (p)
> - cygwin_conv_to_posix_path (p, buf);
> + cygwin_conv_path (CCP_WIN_A_TO_POSIX, p, buf, PATH_MAX);
> else
> - cygwin_conv_to_posix_path (default_nto_target, buf);
> + cygwin_conv_path (CCP_WIN_A_TO_POSIX, default_nto_target, buf,
> PATH_MAX);
> return buf;
> #else
> return p ? p : default_nto_target;
--
Joel