This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 0/3] readline-6.2 rebase


> Do you think it should be checked in as separate patches (to unchanged
> readline-6.2 with each of the patches applied afterwards) or as a single
> commit?

(just my 2 cents)

I'm sensitive to the 'git bisect' argument, and I think that it's easy
to recreate the local diff. Also, I think we've always submitted the
vast majority of changes we make to readline, so of the changes should
no longer be needed at the next update. So a single-commit would be
my prefered option.

But I don't have a strong opinion. A multi-commit would be fine as well.
Or we could cut the cake in the middle, and make 2 commits: one resetting
readline with no change, and then one commit with all our local changes.

-- 
Joel


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]