This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH : allow to set length of hw watchpoints (e.g. for Valgrind gdbserver)


Note that I have kept 'int' as all other similar variables are int, and an int
will be large enough for any reasonable watchpoint.

I'm not convinced, but I'll let others speak up.
I was also (initially) convinced to go for ssize_t.
But the reason given above + the fact that I could not find the equivalent of add_setshow_zinteger_cmd for an ssize_t made me believe an int was
good enough.
For sure, if such an equivalent exists, it will be trivial to change to ssize_t.
Without such an equivalent, there will be some more work
to define e.g. add_setshow_zssize_t_cmd.


These are fine, but please leave 2 spaces between sentences in the
NEWS entry.
I assume there will be some other comments (maybe related to ssize_t).
I will update NEWS together with handling the other comments.

Thanks again for the review.

Philippe


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]