This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] sim: glue: implement or/xor funcs


>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

Mike> The glue device has a bunch of "todos" for the misc bitwise devices.
Mike> So implement two for fun -- the glue-or and glue-xor.

I'm sorry this went unreviewed for so long.  This happens to many of
your patches; for my part, I don't really know anything about sim, so I
generally do not review it.  I think this is a problem that we should
address one way or another -- either by someone stepping up to do sim
reviews in a more timely way, or by relaxing the rules.

Mike> -	HW_TRACE ((me, "and - port %d, level %d arrived - output %d",
Mike> -		   my_port, level, glue->output[0]));
[...]
Mike> +  /* If we fell through, we want to generate a port event.  */
Mike> +  HW_TRACE ((me, "port %d, level %d arrived - output %d",
Mike> +	     my_port, level, glue->output[0]));

This remotes the "and - " string from the HW_TRACE call.
Is this important?  I have no idea.

The rest of the patch seems unobjectionable to me.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]