This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 3/4] aix: add support for dwarf2.


>>>>> "Tristan" == Tristan Gingold <gingold@adacore.com> writes:

Tristan> +static const struct dwarf2_debug_sections dwarf2_xcoff_names = {
Tristan> +  { ".dwinfo", NULL },
Tristan> +  { ".dwabrev", NULL },
Tristan> +  { ".dwline", NULL },
Tristan> +  { ".dwloc", NULL },
Tristan> +  { NULL, NULL }, /* debug_macinfo */
Tristan> +  { ".dwstr", NULL },
Tristan> +  { ".dwrnges", NULL },
Tristan> +  { NULL, NULL }, /* debug_types */
Tristan> +  { ".dwframe", NULL },
Tristan> +  { NULL, NULL }, /* eh_frame */
Tristan> +  { NULL, NULL } /* gdb_index */
Tristan> +};

I don't like this approach, because it requires some non-obvious code
synchronization between this struct and dwarf2read.  I think some kind
of name mapping approach would be preferable -- that way, we would be
free to change dwarf2read without needing to update structs in other
parts of gdb.

If you don't want to do this in BFD, I think it would be fine to do it
locally in gdb.

What do you think?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]