This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [rfc 2/2] Follow DW_AT_linkage_name for methods [Re: The future of dwarf2_physname]


>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:

Jan> Also after a chat with Tom Tromey I no longer use DMGL_RET_POSTFIX.
Jan> That is for ELF symbol `long m<char>()' GDB with proposed patch
Jan> uses `m<char>()' (and not `m<char>()long').  This is compatible
Jan> with gdb-7.2 (physname) template functions.

This patch looks pretty good to me.

Keith, are there parts of your series which are still needed for 7.3 if
this patch is committed there?

The new command probably needs documentation (it is unclear to me
whether we document, or even whether we should document, "set debug"
commands).

Jan> +	  canon = (char *) mangled;

I think 'canon' can be made const and this cast reomved.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]