This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [_Complex test 1/4] support_complex_tests in gdb.exp and pass _Complex args to func


>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:

Tom> I am curious if you tested this in some situation where the complex
Tom> tests are skipped.

Yao> I simulate the `complex-unsupported platform' by removing "o" in keyword
Yao> "double" in support_complex_tests, "_Complex double cd;" -> "_Complex
Yao> duble cd;", and run gdb.base/varargs.exp again.  As you can see,
Yao> _Complex related tests are skipped.

Sounds good, thanks.

Just a couple trivial nits.

Yao> +proc  complex_integral_args {} {

Extra space.

Yao> +# Locate acual args; _Complex types and integral/float.

Typo: actual.

Ok with those fixed.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]