This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[commit] ppc sim: Improve invalid option error message
- From: Joel Brobecker <brobecker at adacore dot com>
- To: gdb-patches at sourceware dot org
- Cc: Joel Brobecker <brobecker at adacore dot com>
- Date: Wed, 8 Jun 2011 09:50:19 -0700
- Subject: [commit] ppc sim: Improve invalid option error message
This patch improves the error message when an invalid option is
detected, by also printing the option that actually caused the error.
For instance, from GDB:
(gdb) target sim --hello
Invalid option: --hello
Usage:
[...]
We also added the usage after an invalid long-name option (Eg: --hello)
to be in line with what's being done for all other invalid options
being detected.
sim/ppc/ChangeLog:
* psim.c (psim_options): Add option that cause the error
in invalid-option error messages. Print the usage when
detecting an invalid long-name option.
---
sim/ppc/ChangeLog | 8 +++++++-
sim/ppc/psim.c | 7 ++++++-
2 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/sim/ppc/ChangeLog b/sim/ppc/ChangeLog
index 2536fa4..047126a 100644
--- a/sim/ppc/ChangeLog
+++ b/sim/ppc/ChangeLog
@@ -1,4 +1,10 @@
-2011-06-08 Joel Brobecker <brobecker@adacore.com>
+2011-06-08 joel brobecker <brobecker@adacore.com>
+
+ * psim.c (psim_options): Add option that cause the error
+ in invalid-option error messages. Print the usage when
+ detecting an invalid long-name option.
+
+2011-06-08 joel brobecker <brobecker@adacore.com>
* psim.c (psim_options): Accept and ignore `--sysroot=...'.
diff --git a/sim/ppc/psim.c b/sim/ppc/psim.c
index 076a50c..d814486 100644
--- a/sim/ppc/psim.c
+++ b/sim/ppc/psim.c
@@ -261,6 +261,7 @@ psim_options(device *root,
while (*p != '\0') {
switch (*p) {
default:
+ printf_filtered ("Invalid Option: %s\n", argv[argp]);
psim_usage(0, 0);
error ("");
break;
@@ -368,7 +369,11 @@ psim_options(device *root,
exit (0);
}
else
- error("Unrecognized option");
+ {
+ printf_filtered ("Invalid option: %s\n", argv[argp]);
+ psim_usage (0, 0);
+ error ("");
+ }
break;
}
p += 1;
--
1.7.1