Re: [PATCH] gdb: sim: automatically pass down sysroot

[Mike Frysinger <vapier at gentoo dot org>]

On Wednesday, June 08, 2011 12:49:39 Joel Brobecker wrote:
> > 2011-05-26  Mike Frysinger  <vapier@gentoo.org>
> > 
> > 	* remote-sim.c (gdbsim_open): Add the strlen of " --sysroot=" and
> > 	gdb_sysroot to the "len" variable.  Append both to "arg_buf".
> 
> It turns out that this is breaking some simulators, at least the ppc sim:
> 
>         % powerpc-elf-gdb
>         (gdb) target sim
>         Unrecognized option
> 
> The problem is that some sims have their own argument parsing,
> and they sometimes reject the --sysroot= option.  Here is the patch
> I just checked in to fix the ppc, but I think that other simulators
> might have the same problem.  I checked a few, and I think that
> the d10v sim, for instance, will also need to be updated).
> 
> So, we have a decision to make: Either do a pass over all simulators,
> and fix the ones that need fixing, or revert (in which case my ppc
> patch also needs to be reverted).

i'll take a look over the sims to see which lack sysroot support and fix them 
up ... really wish people would use the common/ dir more as this keeps biting 
me :/
-mike

Attachment: signature.asc
Description: This is a digitally signed message part.