This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/2] Code cleanup: New symbol_filename_ftype
- From: Joel Brobecker <brobecker at adacore dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 10 Jun 2011 14:24:00 -0700
- Subject: Re: [patch 1/2] Code cleanup: New symbol_filename_ftype
- References: <20110610202912.GA31746@host1.jankratochvil.net>
> I will check it in less than a week.
I'd just go ahead and check in now. Patches like these are great, IMO.
Note that it gives us an opportunity to document the meaning of the
various parameters (I am also a fan of naming the parameters in
declarations as well, as Jan did here).
> gdb/
> 2011-06-10 Jan Kratochvil <jan.kratochvil@redhat.com>
>
> Code cleanup.
> * dwarf2read.c (dw2_map_symbol_filenames): Use symbol_filename_ftype
> for fun.
> * psymtab.c (map_symbol_filenames_psymtab)
> (map_partial_symbol_filenames): Likewise.
> * psymtab.h: Include symfile.h.
> (map_partial_symbol_filenames): Use symbol_filename_ftype for fun.
> * symfile.h (symbol_filename_ftype): New.
> (struct quick_symbol_functions): Use symbol_filename_ftype for fun of
> map_symbol_filenames, clarify more the naming in comment.
Looks good to me.
--
Joel