Re: [patch] failed to attach to the same process after detaching in gdbserver multiprocess mode

[Joel Brobecker <brobecker at adacore dot com>]

Liang,

Thanks for sending these patches in.  I can't really approve your
patches since I don't have expertise in that area, but I can comment
on a couple of things:
  - It's great that you take the time to explain what the problem is;
  - Patches should have a ChangeLog entry to accompany them;
  - One nit: It's awesome that you take the time to add comments
    to document the code, and we don't use them often enough IMO.
    But I think that, in general, we want the comments in the code
    to say *why* you do what you do.  And oh, comments should start
    with a capital letter, and end with a period (and we always put
    2 spaces after period, even before a closing */

> +
> +  /* reset cont_thread */
> +  cont_thread = null_ptid;
>    return 0;

-- 
Joel