Re: [PATCH/RFC] gdb: tests: add support for testing FLAT toolchains

[Pedro Alves <pedro at codesourcery dot com>]

On Friday 01 July 2011 16:55:02, Mike Frysinger wrote:

> i dont need the logic to be in the core gdb testsuite, but i think it
> does have to be in the gdb testsuite somewhere.  i dont think making
> all board porters do the same thing over and over again is the right
> path.  after all, this is going to be the same issue across all
> toolchains that target this binary format.  which is what we just
> found out since i doubt the code you have is for Blackfin processors
> :).

:-)  Yes, agreed.

> it seems like the shlib/exec hooks you mention should be sufficient.
> do you know why in your setup you still need to bang on gdb_compile ?

Hmm.  The gdb_compile overriding was added much earlier on our 
board files than the new hooks.  The hooks were added recently,
to fix the gdb.base/reread.exp test on flt targets.  It's sole
purpose is to the the same renaming dance you have.
That is, IIUC, if we don't do the gdb_compile overriding + .flt
renaming, as is, tests will still try to load the FLAT file, instead
of the .gdb file.  exec_symbol_file/exec_target_file are only used
in gdb_rename_execfile/gdb_touch_execfile presently.  :-/
Maybe there's some central places, like gdb_load, where we
should be using exec_symbol_file on?  Not sure what else (if
anything) would break; some tests themselves might need some
output adjustment.

-- 
Pedro Alves