This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Display var_zinteger as signed


On 04/07/2011 12:26, Andreas Schwab wrote:
"Andrew Burgess"<aburgess@broadcom.com> writes:

< something with a really silly mistake in >

The "unlimited" case should not fall through.

Ooops. Thanks for pointing that out. Updated patch below.


Thanks,
Andrew


2011-07-04 Andrew Burgess <aburgess@broadcom.com>


	* cli/cli-setshow.c (do_setshow_command): Display var_zinteger
	variables as signed, not unsigned.

diff --git a/gdb/cli/cli-setshow.c b/gdb/cli/cli-setshow.c
index 6acdd91..868fff1 100644
--- a/gdb/cli/cli-setshow.c
+++ b/gdb/cli/cli-setshow.c
@@ -365,16 +365,17 @@ do_setshow_command (char *arg, int from_tty, struct cmd_list_element *c)
}
/* else fall through */
case var_zuinteger:
- case var_zinteger:
fprintf_filtered (stb->stream, "%u", *(unsigned int *) c->var);
break;
case var_integer:
if (*(int *) c->var == INT_MAX)
{
fputs_filtered ("unlimited", stb->stream);
+ break;
}
- else
- fprintf_filtered (stb->stream, "%d", *(int *) c->var);
+ /* else fall through */
+ case var_zinteger:
+ fprintf_filtered (stb->stream, "%d", *(int *) c->var);
break;


default:


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]