This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
[4/4] RFC: dynamic arrays and DW_FORM_exprloc
- From: Tom Tromey <tromey at redhat dot com>
- To: gdb-patches at sourceware dot org
- Cc: Jan Kratochvil <jkratoch at redhat dot com>
- Date: Fri, 15 Jul 2011 12:08:51 -0600
- Subject: [4/4] RFC: dynamic arrays and DW_FORM_exprloc
A -gdwarf-4 regression:
-PASS: gdb.fortran/multi-dim.exp: print valid variable bound array element
+FAIL: gdb.fortran/multi-dim.exp: print valid variable bound array element
The bug here is that with DWARF 4, GCC uses DW_FORM_exprloc when
emitting the bounds of a variably-sized array. GDB, however, only
checks for DW_FORM_block1.
Jan, any comments?
Built and regtested by the buildbot.
Tom
b/gdb/ChangeLog:
2011-07-15 Tom Tromey <tromey@redhat.com>
* dwarf2read.c (read_subrange_type): Check for DW_FORM_exprloc for
variable-sized array.
>From fcf10915409297cb512e12e3b8ef285aa125dfc6 Mon Sep 17 00:00:00 2001
From: Tom Tromey <tromey@redhat.com>
Date: Fri, 15 Jul 2011 11:35:35 -0600
Subject: [PATCH 4/4] also recognize DW_FORM_exprloc as dynamic range
---
gdb/ChangeLog | 5 +++++
gdb/dwarf2read.c | 7 +++++--
2 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/gdb/dwarf2read.c b/gdb/dwarf2read.c
index 8a6b142..fe6f189 100644
--- a/gdb/dwarf2read.c
+++ b/gdb/dwarf2read.c
@@ -8623,7 +8623,9 @@ read_subrange_type (struct die_info *die, struct dwarf2_cu *cu)
attr = dwarf2_attr (die, DW_AT_upper_bound, cu);
if (attr)
{
- if (attr->form == DW_FORM_block1 || is_ref_attr (attr))
+ if (attr->form == DW_FORM_block1
+ || attr->form == DW_FORM_exprloc
+ || is_ref_attr (attr))
{
/* GCC encodes arrays with unspecified or dynamic length
with a DW_FORM_block1 attribute or a reference attribute.
@@ -8706,7 +8708,8 @@ read_subrange_type (struct die_info *die, struct dwarf2_cu *cu)
/* Mark arrays with dynamic length at least as an array of unspecified
length. GDB could check the boundary but before it gets implemented at
least allow accessing the array elements. */
- if (attr && attr->form == DW_FORM_block1)
+ if (attr && (attr->form == DW_FORM_block1
+ || attr->form == DW_FORM_exprloc))
TYPE_HIGH_BOUND_UNDEFINED (range_type) = 1;
/* Ada expects an empty array on no boundary attributes. */
--
1.7.6