This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] refactor arm-tdep.c:install_ldr_str_ldrb_strb to handle halfword
- From: "Ulrich Weigand" <uweigand at de dot ibm dot com>
- To: yao at codesourcery dot com (Yao Qi)
- Cc: gdb-patches at sourceware dot org
- Date: Fri, 15 Jul 2011 20:49:59 +0200 (CEST)
- Subject: Re: [patch] refactor arm-tdep.c:install_ldr_str_ldrb_strb to handle halfword
Yao Qi wrote:
> * arm-tdep.c (install_ldr_str_ldrb_strb): Renamed to ...
> (install_load_store): ... this. New.
> Change parameter BYTE to SIZE.
> (arm_copy_ldr_str_ldrb_strb): Update caller.
> (arm_decode_ld_st_word_ubyte): Update caller.
This is OK. It might be a good idea now to use the new
install_load_store routine also for arm_copy_extra_ld_st
(which is where half-/doubleword instructions are decoded
for ARM) to reduce some duplication. But that could also
be done as a follow-on patch ...
Thanks,
Ulrich
--
Dr. Ulrich Weigand
GNU Toolchain for Linux on System z and Cell BE
Ulrich.Weigand@de.ibm.com