This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] PR 12999 info macros command.
- From: Eli Zaretskii <eliz at gnu dot org>
- To: Matt Rice <ratmice at gmail dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 20 Jul 2011 20:04:10 +0300
- Subject: Re: [patch] PR 12999 info macros command.
- References: <CACTLOFot6DnZj173bQTLEqW=XzTDngjCLvpSZv4a-aCKfaLxog@mail.gmail.com>
- Reply-to: Eli Zaretskii <eliz at gnu dot org>
> Date: Mon, 18 Jul 2011 23:57:25 -0700
> From: Matt Rice <ratmice@gmail.com>
>
> this patch adds 2 commands,
> info macros LINESPEC
> info definitions MACRO
Thanks. A few minor comments and a question.
> +@cindex definition, showing a macro's
That sounds awkward. Suggest "@cindex definition of a macro, showing"
instead.
> +@item info macros @var{linespec}
> +Show all macro definitions at the location of @var{linespec}, and describe the
Suggest a slight rewording:
Show all macro definitions that are in effect at the location
specified by @var{linespec}, and describe ...
> +@cindex definition, showing a macro's
It's not useful to have identical index entries so close to one
another. I suggest to remove the second one.
> +Show all definitions of the macro named @var{macro}, in the current scope,
It might be better to say "... definitions of the named @var{macro} ...".
Also, what is the "scope" of a macro?