This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [Patch] More responsive QUITs

From: Tom Tromey <tromey at redhat dot com>
To: Sterling Augustine <saugustine at google dot com>
Cc: gdb-patches at sourceware dot org
Date: Thu, 21 Jul 2011 14:42:07 -0600
Subject: Re: [Patch] More responsive QUITs
References: <CAEG7qUyG6S3pFiXsC2uyiPm8-WSexXBF64Gy+ARnF-wb30uKEA@mail.gmail.com> <m3wrfj9sr2.fsf@fleche.redhat.com> <CAEG7qUynN3k1zkWU6qLOKr0DY8sby5ovqVukNArmFZo_4UW3iA@mail.gmail.com>

>>>>> "Sterling" == Sterling Augustine <saugustine@google.com> writes:

Sterling> 2011-07-20  Sterling Augustine  <saugustine@google.com>
Sterling>        * psymtab.c (map_symbol_filenames_psymtab): Call QUIT.

I think this exposes gdb to a memory leak in
make_source_files_completion_list.

I think the bug is a QUIT can unwind:

   map_symbol_filenames_psymtab
-> map_partial_symbol_filenames
-> make_source_files_completion_list

... which does not use cleanups to protect the allocations it does.

Tom

References:
- [Patch] More responsive QUITs
  - From: Sterling Augustine
- Re: [Patch] More responsive QUITs
  - From: Tom Tromey
- Re: [Patch] More responsive QUITs
  - From: Sterling Augustine

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]