This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [0/6] breakpoints_ops for all kinds of breakpoints


On Friday 22 July 2011 18:32:59, Phil Muldoon wrote:
> Pedro Alves <pedro@codesourcery.com> writes:
> 
> > I did yet a bit more work on:
> >
> >  <http://sourceware.org/ml/gdb-patches/2011-06/msg00374.html>
> >
> > This converts all breakpoint kinds to the breakpoint_ops
> > mechanism.
> >
> > IMO, this is committable as is.  WDYT?
> 
> I think it is great.  It clears up several (dozen) ambiguities with
> breakpoint operations.  I don't think this will affect the Python
> breakpoint_ops work (other than some refactoring, but we'll come to that
> bridge when your work is checked in).

Yeah, I don't think your current patch would need more than a
some trivial updates, but then again, I did leave the print_one
method behind in this conversion, which was the method that
I raised having the issue that doesn't seem to fit for gdb's own
breakpoints currently, so we should clean that up before
considering exposing it as public API.

-- 
Pedro Alves


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]