This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC][patch] Make DCACHE_LINE runtime-settable

>>>>> "Pedro" == Pedro Alves <pedro@codesourcery.com> writes:

>> +/* BLOCK_FUNC routine for dcache_free.  */
>> +
>> +static void
>> +free_block (struct dcache_block *block, void *param)
>> +{
>> +  free (block);

Pedro> xfree.

This one is just moving code from one spot to another.
I don't mind it if Paul wants to fix it, but I think as a rule we
shouldn't "review the context" and make patch submitters fix nits which
already appear in the source.

Tom
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]