This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFA 6/8] New port: TI C6x: gdbserver
> Date: Wed, 27 Jul 2011 11:45:24 +0800
> From: Yao Qi <yao@codesourcery.com>
> CC: gdb-patches@sourceware.org
>
> I've sorted this into alpha-beta order in new patch. Eli, could you
> have a review on new document part in this patch?
Here goes:
> gdb/doc/
> * gdb.texinfo: Document C6x features.
You need to state the name of the node here, see the other log
entries.
> +@node C6x Features
> +@subsection C6x Features
How about using a more full/explicit name of the target in the
subsection name? After all, C6x is just an abbreviation/acronym. I
would assume that users of these targets will at least expect to see
something like TMS320C6x, if not "Texas Instruments".
> +@cindex target descriptions, C6x features
Same here: I would suggest an additional @cindex entry with the full
name.
> +The @samp{org.gnu.gdb.tic6x.core} feature is required for C6x
> +targets.
Same here: mention the full name in the text once.
What about NEWS? do we want this addition mentioned there?
> gdb/
> * features/Makefile (WHICH): Add tic6x-c64xp-linux tic6x-c64x-linux
> and tic6x-c62x-linux.
> * features/tic6x-c6xp.xml: New.
> * features/tic6x-core.xml: New.
> * features/tic6x-gp.xml: New.
> * features/tic6x-c62x-linux.xml: New.
> * features/tic6x-c64x-linux.xml: New.
> * features/tic6x-c64xp-linux.xml: New.
> * features/tic6x-c64xp-linux.c: Generated.
> * features/tic6x-c64x-linux.c: Generated.
> * features/tic6x-c62x-linux.c: Generated.
> * regformats/tic6x-c62x-linux.dat: Generated.
> * regformats/tic6x-c64x-linux.dat: Generated.
> * regformats/tic6x-c64xp-linux.dat: Generated.
Quite a few of these files will trigger ARI alerts about file-name
collisions on 8+3 filesystems. Please consider updating fnchange.lst.