This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch 10/12] entryval: @entry values even for references


On Tue, 19 Jul 2011 17:49:01 +0200, Tom Tromey wrote:
> >>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
> 
> Jan> +	  if (VALUE_LVAL (original_value) == lval_computed)
[...]
> 
> This code is repeated a few times.  I think it should go into a new
> function.

done.

> I think this should be static.
+ 
> const

done, done.


It will be in a new patchset resubmit.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]