This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [RFC] Make solib_add regex-free
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Sergio Durigan Junior <sergiodj at redhat dot com>
- Date: Tue, 9 Aug 2011 12:10:37 +0100
- Subject: Re: [RFC] Make solib_add regex-free
- References: <m3ty9r9zin.fsf@redhat.com> <20110809095838.GA32172@host1.jankratochvil.net>
On Tuesday 09 August 2011 10:58:38, Jan Kratochvil wrote:
> > +/* GLOBAL FUNCTION
> > +
> > + solib_add -- read in symbol info for newly added shared libraries
> > +
> > + SYNOPSIS
> > +
> > + void solib_add (VEC(so_list_p) *so_list, int from_tty,
> > + struct target_ops *target, int readsyms)
> > +
> > + DESCRIPTION
> > +
>
> While it was in the GDB code the new code no longer uses so large+duplicate
> headers, this part could be better dropped in new code I think.
Agreed. This came up just recently in the tic6x patches review too.
I think we should rework all such comments in the current codebase
to follow the standard, to avoid proliferation. There aren't that
many. I will do this.
--
Pedro Alves