This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.

From: Sergio Durigan Junior <sergiodj at redhat dot com>
To: Abhijit Halder <abhijit dot k dot halder at gmail dot com>
Cc: Eli Zaretskii <eliz at gnu dot org>, tromey at redhat dot com, pedro at codesourcery dot com, gdb-patches at sourceware dot org, jan dot kratochvil at redhat dot com
Date: Wed, 10 Aug 2011 14:54:12 -0300
Subject: Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
References: <CAOhZP9zU2K01zFDkChtutGT6yJjUeWYeGRNAAgPgM5rKwrgysg@mail.gmail.com> <m3vcuecrrf.fsf@redhat.com> <CAOhZP9yENHtgW4RSMMdnyvfPJ=yovDo_c5fG3KMC4-oa6NJBrw@mail.gmail.com> <201108041029.37721.pedro@codesourcery.com> <m3ty9xz28j.fsf@fleche.redhat.com> <CAOhZP9xXZS=G-5c_sXd8zFRySCLWjt35dx2Xpiu94n9BmzVpQg@mail.gmail.com> <83pqkjx578.fsf@gnu.org> <CAOhZP9xa19dfnO4X8kefqn7+jc1njBpdCx3W45_0RTYO9Q1juA@mail.gmail.com> <CAOhZP9w-7B9R-R-SmXLtK5meK5QQQFwfk4-1dDMe59rD-gQ=yw@mail.gmail.com> <m3pqkib2rf.fsf@redhat.com> <CAOhZP9y2ZA7QXiURPrsm6sp_EH2-Z6cQK_Ze-YF-tHf7ku_k5g@mail.gmail.com> <m3ipq79tie.fsf@redhat.com> <CAOhZP9z7g_JqOi0Twg_sif5g92ses_NZuay8ABVpq1m=iu92=A@mail.gmail.com>

Abhijit Halder <abhijit.k.halder@gmail.com> writes:

> I made the corrections suggested during code review.

Well, from my perspective I don't think I have anything else about the
patch.  However, I have some questions:

1) I don't remember if you already answered that, but do you have a
copyright assignment (or have you started the process to obtain one)?

2) I believe you can start thinking about a testcase for this feature.
I am not sure how you would write this in order to test it on various
operating systems, but I think starting with GNU/Linux is OK for now.
You may want to take a look at the gdb/testsuite directory for some
examples.

3) I also believe that you can write the documentation part for this
patch.  You will also have to write a NEWS entry.

Maybe you can wait a little more until some maintainer reply before
start steps 2 and 3.  Anyway, it's good to start thinking about these
steps.

Regards,

Sergio.

Follow-Ups:
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder

References:
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Sergio Durigan Junior
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Pedro Alves
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Tom Tromey
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Eli Zaretskii
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Sergio Durigan Junior
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Sergio Durigan Junior
- Re: [PATCH] An implementation of pipe to make I/O communication between gdb and shell.
  - From: Abhijit Halder

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]