This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 1/6] Introduce header (jit-reader.in) and modify build system.


On Sat, 20 Aug 2011 08:27:10 +0200, Sanjoy Das wrote:
> --- /dev/null
> +++ b/gdb/jit-reader.in
> @@ -0,0 +1,349 @@
[...]
> +/* Called when the reader is loaded. Must either return a properly
> +   populated gdb_reader_funcs or NULL. The memory allocated for the
> +   gdb_reader_funcs is to be managed by the reader itself (i.e. if it
> +   is allocated from the heap, it must also be freed in
> +   gdb_destroy_reader).  */
> +
> +extern struct gdb_reader_funcs *gdb_init_reader (void);

I think it should be:
extern const struct gdb_reader_funcs *gdb_init_reader (void);

as GDB should never modify it.


Thanks,
Jan


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]