This is the mail archive of the
mailing list for the GDB project.
Re: [PATCH] Fix darwin build error
Josh Matthews <email@example.com> writes:
> I hope this is the right way to do this. GDB currently doesn't build
> on darwin, and this patch makes it do so.
Thanks for this. There are some nits, though.
Also, I don't see your name on the MAINTAINERS file. Do you have
copyright assignment from FSF? I don't know what's the procedure on
these cases... Maybe someone could commit the patch for you?
> 2011-08-22 Josh Matthews <firstname.lastname@example.org>
> Fix build error in darwin port.
You have to cite the file. Also, I believe you could be more
descriptive on the message. Something like:
* darwin-nat-info.c (darwin_debug_regions_recurse): Replacing
`uiout' by `current_uiout', fixing build error.
> --- a/gdb/darwin-nat-info.c
> +++ b/gdb/darwin-nat-info.c
> @@ -620,6 +620,7 @@ darwin_debug_regions_recurse (task_t task)
> kern_return_t kret;
> int ret;
> struct cleanup *table_chain;
> + struct ui_out* uiout = current_uiout;
The `*' shouldn't be placed there. This is the standard:
struct ui_out *uiout = current_uiout;
I think the current approach is to actually replace the occurrences of
`uiout' by `current_uiout', but I don't mind having a local `uiout'