This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] buffer overflow in symtab_from_filename
Aleksandar> In my case, I would get it by command "b main": on entry to
Aleksandar> symtab_from_filename (called from decode_line_1, ln 879),
Aleksandar> argptr points to a pointer to argument passed to 'break'
Aleksandar> command; p (argument value on entry) points to the end of
Aleksandar> the string ('\0'). Then this value is assigned to p1.
I would have thought that lookup_symtab would return NULL here, causing
the throw_error branch to be taken.
I guess it could happen with 'break main.c'.
Aleksandar> I think it is obvious enough to not warrant a separate test case?
I agree.
Patch is ok, please commit.
Tom