This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] Tweak output of -var-info-path-expression
> 2011-08-23 Marc Khouzam <marc.khouzam@ericsson.com>
>
> PR mi/11912
> * varobj.c (cplus_describe_child): Add the keyword
> 'class' to the output of the method when dealing
> with a cast to a base class.
>
> 2011-08-23 Marc Khouzam <marc.khouzam@ericsson.com>
>
> PR mi/11912
> * gdb.mi/mi-inheritance-syntax-error.cc: New file.
> * gdb.mi/mi-inheritance-syntax-error.exp: New file.
> * gdb.mi/mi-var-cp.cc: Updated for new 'class'
> keyword in output of -var-info-path-expression.
[...]
> Do you think it is ok for the 7.3 branch?
No objection for putting it on 7.3 since Tom thinks it's OK.
One nit:
> + When we are in the scope of the base class or of one
> + of its children, the type field name will be interpreted
> + as a constructor, if it exists. Therefore, we must
> + indicate that the name is a class name by using the
> + 'class' keyword. PR mi/11912 */
^^^^
Missing second space after a period. I would also follow the general
GCS guideline that everything is a setence, and thus write something
like: `[...] keyword. See PR mi/11912. */'. But that's only if you
agree, it can be seen as a matter of preference.
--
Joel