This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[obv] testsuite: gdb.trace/*: Use is_lp64_target


Hi,

checked in as obvious.

There are always these FAILs in all the cases, I did not investigate them more.
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argc
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argi
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argf
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argd
FAIL: gdb.trace/unavailable.exp: unavailable arguments: print &argarray

Tested on {x86_64,x86_64-m32,i686}-fedora16pre-linux-gnu.


Thanks,
Jan


http://sourceware.org/ml/gdb-cvs/2011-08/msg00111.html

--- src/gdb/testsuite/ChangeLog	2011/08/18 16:19:00	1.2837
+++ src/gdb/testsuite/ChangeLog	2011/08/26 09:20:43	1.2838
@@ -1,3 +1,11 @@
+2011-08-26  Jan Kratochvil  <jan.kratochvil@redhat.com>
+
+	* gdb.trace/backtrace.exp: Use is_lp64_target to check 64bit target.
+	* gdb.trace/collection.exp: Likewise.
+	* gdb.trace/report.exp: Likewise.
+	* gdb.trace/unavailable.exp: Likewise.
+	* gdb.trace/while-dyn.exp: Likewise.
+
 2011-08-18  Keith Seitz  <keiths@redhat.com>
 
 	PR c++/12266
--- src/gdb/testsuite/gdb.trace/backtrace.exp	2011/01/01 15:33:50	1.18
+++ src/gdb/testsuite/gdb.trace/backtrace.exp	2011/08/26 09:20:44	1.19
@@ -150,10 +150,10 @@
 	"$tdp4" \
 	"collect \$regs, \$args, \$locs" "^$"
 
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
     set fpreg "\$rbp"
     set spreg "\$rsp"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
     set fpreg "\$ebp"
     set spreg "\$esp"
 } else {
--- src/gdb/testsuite/gdb.trace/collection.exp	2011/02/16 18:07:58	1.24
+++ src/gdb/testsuite/gdb.trace/collection.exp	2011/08/26 09:20:44	1.25
@@ -45,11 +45,11 @@
 set ws "\[\r\n\t \]+"
 set cr "\[\r\n\]+"
 
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
     set fpreg "rbp"
     set spreg "rsp"
     set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
     set fpreg "ebp"
     set spreg "esp"
     set pcreg "eip"
--- src/gdb/testsuite/gdb.trace/report.exp	2011/03/07 20:25:57	1.19
+++ src/gdb/testsuite/gdb.trace/report.exp	2011/08/26 09:20:44	1.20
@@ -159,11 +159,11 @@
 	"$tdp4" \
 	"collect \$locs" "^$"
 
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
     set fpreg "rbp"
     set spreg "rsp"
     set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
     set fpreg "ebp"
     set spreg "esp"
     set pcreg "eip"
--- src/gdb/testsuite/gdb.trace/unavailable.exp	2011/08/05 15:17:59	1.9
+++ src/gdb/testsuite/gdb.trace/unavailable.exp	2011/08/26 09:20:44	1.10
@@ -30,11 +30,11 @@
 set ws "\[\r\n\t \]+"
 set cr "\[\r\n\]+"
 
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
     set fpreg "rbp"
     set spreg "rsp"
     set pcreg "rip"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
     set fpreg "ebp"
     set spreg "esp"
     set pcreg "eip"
@@ -295,12 +295,12 @@
 
     # Test reading uncollected pseudo-registers.  The set of which
     # depends on target.
-    if [istarget "x86_64-*"] then {
+    if {$pcreg == "rip"} then {
 	# Check the raw register first.
 	test_register_unavailable "\$rax"
 	test_register_unavailable "\$eax"
 	test_register_unavailable "\$ax"
-    } elseif [istarget "i?86-*"] then {
+    } elseif {$pcreg == "eip"} then {
 	# Check the raw register first.
 	test_register_unavailable "\$eax"
 	test_register_unavailable "\$ax"
--- src/gdb/testsuite/gdb.trace/while-dyn.exp	2011/01/01 15:33:50	1.18
+++ src/gdb/testsuite/gdb.trace/while-dyn.exp	2011/08/26 09:20:44	1.19
@@ -52,9 +52,9 @@
 # test while-stepping dynamically (live target)
 #
 
-if [istarget "x86_64-*"] then {
+if {([istarget "x86_64-*"] || [istarget "i?86-*"]) && [is_lp64_target]} then {
     set fpreg "\$rbp"
-} elseif [istarget "i?86-*"] then {
+} elseif {[istarget "x86_64-*"] || [istarget "i?86-*"]} then {
     set fpreg "\$ebp"
 } else {
     set fpreg "\$fp"


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]