This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch 1/2] Code cleanup: Split value_of_this to &{,_silent}
- From: Tom Tromey <tromey at redhat dot com>
- To: Jan Kratochvil <jan dot kratochvil at redhat dot com>
- Cc: gdb-patches at sourceware dot org
- Date: Wed, 31 Aug 2011 10:06:35 -0600
- Subject: Re: [patch 1/2] Code cleanup: Split value_of_this to &{,_silent}
- References: <20110831155801.GA16329@host1.jankratochvil.net>
>>>>> "Jan" == Jan Kratochvil <jan.kratochvil@redhat.com> writes:
Jan> I find this as a code cleanup on its own but it is more clear with the
Jan> [patch 2/2] where value_of_this would need to TRY_CATCH during complain==0
Jan> case and the code got very ugly afterwards.
Looks good to me. I prefer this style as well, "complain"-like
arguments make the API weird to use.
Tom