This is the mail archive of the
gdb-patches@sourceware.org
mailing list for the GDB project.
Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target
- From: Pedro Alves <pedro at codesourcery dot com>
- To: gdb-patches at sourceware dot org
- Cc: Jan Kratochvil <jan dot kratochvil at redhat dot com>, Mark Kettenis <mark dot kettenis at xs4all dot nl>, hjl dot tools at gmail dot com
- Date: Thu, 8 Sep 2011 16:53:34 +0100
- Subject: Re: [patch] testsuite: Fix x32, introduce is_amd64_regs_target
- References: <20110826092539.GA23720@host1.jankratochvil.net> <201108282105.p7SL5YAL006825@glazunov.sibelius.xs4all.nl> <20110908153454.GE23706@host1.jankratochvil.net>
On Thursday 08 September 2011 16:34:54, Jan Kratochvil wrote:
> On Sun, 28 Aug 2011 23:05:34 +0200, Mark Kettenis wrote:
> > > From: Jan Kratochvil <jan.kratochvil@redhat.com>
> > > x32 uses triple x86_64-x32-linux* which matches x86_64-*-*.
> >
> > Uh, that's wrong. The middle part if the target triplet is supposed
> > to be the hardware vendor. For i386/amd64 this is pretty much
> > meaningles, but attaching a new meaning to it would be a mistake.
> >
> > Fortunately, your diff doesn't really depend on this. But I think you
> > should adjust the comments in the code.
>
> The triple x86_64-x32-linux* is a reality in binutils, gcc etc., I believe if
> it should be changed GDB is not the place to start such change.
I don't believe that triplet was ever accepted. At least I don't see it
in mainline src/ anywhere. GDB trunk itself doesn't support x32 yet. If
there were bits that depended on the triplet, they'd be appropriate on
the x32 branch instead, not in trunk yet.
> And the comments should reflect the reality.
>
> OK to check it in as is?
>
>
> Thanks,
> Jan
>
--
Pedro Alves