This is the mail archive of the gdb-patches@sourceware.org mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] Preliminary work in fork_inferior


On Sep 16, 2011, at 4:57 PM, Pedro Alves wrote:

> On Friday 16 September 2011 15:47:19, Tristan Gingold wrote:
>> 
>> On Sep 16, 2011, at 3:19 PM, Pedro Alves wrote:
>> 
>>> Thanks, this is okay.
>>> 
>>> On Friday 16 September 2011 13:28:59, Tristan Gingold wrote:
>>>> +      /* If we get here, it's an error.  */
>>>>      if (shell)
>>>>       {
>>>> -         execlp (shell_file, shell_file, "-c", shell_command, (char *) 0);
>>>> -
>>>> -         /* If we get here, it's an error.  */
>>>>         fprintf_unfiltered (gdb_stderr, "Cannot exec %s: %s.\n", shell_file,
>>>>                             safe_strerror (errno));
>>> 
>>> I wouldn't mind merging the "Cannot exec" bits of both branches as well,
>>> always printing the whole argv.
>> 
>> Ok, so more cleanup.  Something like that ?
> 
> Looks greak, thanks!  Please apply.

Thanks, now committed.

Tristan.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]